Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requested adblocker l10n changes #15974

Merged

Conversation

maureenlholland
Copy link
Collaborator

@maureenlholland maureenlholland commented Feb 4, 2025

If this changeset needs to go into the FXC codebase, please add the WMO and FXC label.

One-line summary

Final polish on the adblocker updates: #15959
l10n requested changes here: mozilla-l10n/www-l10n#473 (review)

Testing

You might need to set Dev=False in your .env to see the older version of the page.

http://localhost:8000/en-US/firefox/features/adblocker/

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.60%. Comparing base (639a535) to head (9534f7a).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
bedrock/firefox/views.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15974   +/-   ##
=======================================
  Coverage   79.60%   79.60%           
=======================================
  Files         160      160           
  Lines        8410     8410           
=======================================
  Hits         6695     6695           
  Misses       1715     1715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maureenlholland maureenlholland added P2 Second level priority - Should have Needs Review Awaiting code review Review: XS Code review time: up to 30min WMO and FXC Code relevant to both the WMO and FXC projects labels Feb 4, 2025
@maureenlholland maureenlholland marked this pull request as ready for review February 4, 2025 20:33
@maureenlholland maureenlholland requested review from a team as code owners February 4, 2025 20:33
@wen-2018 wen-2018 self-assigned this Feb 4, 2025
@wen-2018 wen-2018 removed the Needs Review Awaiting code review label Feb 4, 2025
Copy link
Collaborator

@wen-2018 wen-2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@wen-2018 wen-2018 merged commit b18326f into mozilla:main Feb 4, 2025
6 checks passed
@alexgibson alexgibson added Applied to Springfield Has been applied to Springfield after having WMO + FXC label and removed WMO and FXC Code relevant to both the WMO and FXC projects labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applied to Springfield Has been applied to Springfield after having WMO + FXC label P2 Second level priority - Should have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants