Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

Upgrade Django to v2.1.7 #1755

Merged
merged 3 commits into from
Feb 28, 2019
Merged

Upgrade Django to v2.1.7 #1755

merged 3 commits into from
Feb 28, 2019

Conversation

rehandalal
Copy link
Contributor

Blocked by #1752.

r?

@rehandalal
Copy link
Contributor Author

Hmm... Looks like some autograph issues...

@mythmon
Copy link
Contributor

mythmon commented Feb 25, 2019

I think we don't usually use Autograph itself during tests, but instead are doing mocked signing by making the "signature" actually a normal hash of the data. I don't know why that would break in the update though. I skimmed through the release note and didn't find anything that seemed relevant.

@peterbe
Copy link
Contributor

peterbe commented Feb 28, 2019

@rehandalal can you fix the conflicts and then I can review this.

@peterbe
Copy link
Contributor

peterbe commented Feb 28, 2019

"review" :)

@rehandalal rehandalal requested a review from mythmon February 28, 2019 21:13
@rehandalal rehandalal assigned mythmon and unassigned rehandalal Feb 28, 2019
@mythmon
Copy link
Contributor

mythmon commented Feb 28, 2019

@rehandalal can you check what you get at /api/docs/? It isn't working for me, due to not being able to find jquery, but I also have some other weird stuff happening, so I'm not sure.

Besides that, everything I checked seems to work fine.

@rehandalal
Copy link
Contributor Author

image

Appears to be an inline script CSP issue.

@rehandalal
Copy link
Contributor Author

I hit refresh and it looked okay though...

image

Still seeing the CSP issues in the console however.

@mythmon
Copy link
Contributor

mythmon commented Feb 28, 2019

The CSP stuff is probably from #1765. You're getting way farther than I am, so I think this is ok.

mythmon
mythmon approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@mythmon mythmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Feb 28, 2019
@bors @rehandalal
Merge #1755
5718076 
1755: Upgrade Django to v2.1.7 r=mythmon a=rehandalal

Blocked by #1752.

r?

Co-authored-by: Rehan Dalal <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 28, 2019

Build succeeded

@bors bors bot merged commit ebd0c1c into mozilla:master Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mythmon mythmon mythmon approved these changes

Assignees

@mythmon mythmon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rehandalal @mythmon @peterbe