Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing return type for PDFWorker.fromPort() #19571

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

yjoer
Copy link
Contributor

@yjoer yjoer commented Feb 27, 2025

The TypeScript compiler did not infer the return type from the returned instance, defaulting to any. This PR adds an annotation to explicitly define the return type.

Before:

static fromPort(params: PDFWorkerParameters): any;

After:

static fromPort(params: PDFWorkerParameters): PDFWorker;

@timvandermeij timvandermeij merged commit 93759f3 into mozilla:master Mar 2, 2025
9 checks passed
@timvandermeij
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants