Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to use auto-linking in XFA documents (PR 19110 follow-up) #19574

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Feb 28, 2025

Auto-linking requires a normal textLayer which XFA documents obviously don't have, and currently XFA documents cause "pointless" error messages to be logged in the console.

@Snuffleupagus Snuffleupagus added viewer release-blocker Blocker for the upcoming release labels Feb 28, 2025
@Snuffleupagus Snuffleupagus force-pushed the autolinking-xfa-disable branch from 59bbe3d to 5498950 Compare February 28, 2025 11:49
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8df41d50248ca90/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/370ad647ab56e11/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/370ad647ab56e11/output.txt

Total script time: 11.44 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/8df41d50248ca90/output.txt

Total script time: 28.90 mins

  • Integration Tests: FAILED

Auto-linking requires a normal textLayer which XFA documents obviously don't have, and currently XFA documents cause "pointless" error messages to be logged in the console.
@Snuffleupagus Snuffleupagus force-pushed the autolinking-xfa-disable branch from 5498950 to 7273db2 Compare February 28, 2025 13:48
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ac0733cb0f67aec/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/ac0733cb0f67aec/output.txt

Total script time: 11.59 mins

  • Integration Tests: FAILED

@Snuffleupagus Snuffleupagus merged commit 6e1cfa2 into mozilla:master Feb 28, 2025
7 checks passed
@Snuffleupagus Snuffleupagus deleted the autolinking-xfa-disable branch February 28, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker Blocker for the upcoming release viewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants