Add a GlobalColorSpaceCache to reduce unnecessary re-parsing
#19583
Conversation
Snuffleupagus
force-pushed
the
GlobalColorSpaceCache
branch
2 times, most recently
from
7be942b to
61ab23d
Compare
|
Overall it looks good. |
Snuffleupagus
force-pushed
the
GlobalColorSpaceCache
branch
from
61ab23d to
24207ae
Compare
Perhaps, but I'd feel more comfortable if we didn't try that in this PR to reduce the risk of accidentally breaking something. |
Snuffleupagus
force-pushed
the
GlobalColorSpaceCache
branch
from
24207ae to
4c08c50
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b5ed94537d942ee/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/418467d16af0778/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b5ed94537d942ee/output.txt Total script time: 2.37 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/418467d16af0778/output.txt Total script time: 7.80 mins
|
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/52fea2f185cc687/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e4111273055d4c2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e4111273055d4c2/output.txt Total script time: 16.94 mins
|
This complements the existing `LocalColorSpaceCache`, which is unique to each `getOperatorList`-invocation since it also caches by `Name`, which should help reduce unnecessary re-parsing especially for e.g. `ICCBased` ColorSpaces once we properly support those.
Snuffleupagus
force-pushed
the
GlobalColorSpaceCache
branch
from
4c08c50 to
4be7974
Compare
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/52fea2f185cc687/output.txt Total script time: 30.64 mins
|
This complements the existing
LocalColorSpaceCache, which is unique to eachgetOperatorList-invocation since it also caches byName, which should help reduce unnecessary re-parsing especially for e.g.ICCBasedColorSpaces once we properly support those.