-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use arrow functions with some Promise.then
calls
#19597
Use arrow functions with some Promise.then
calls
#19597
Conversation
A lot of this is fairly old code, which we can shorten slightly by using arrow functions instead of "regular" functions.
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e729edb7172a72c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b713a3b7bace88e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b713a3b7bace88e/output.txt Total script time: 2.35 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/e729edb7172a72c/output.txt Total script time: 7.31 mins
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f72832ccf9e5dc9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/426c3c9a1147572/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f72832ccf9e5dc9/output.txt Total script time: 16.86 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/426c3c9a1147572/output.txt Total script time: 30.65 mins
|
Thank you for modernizing this code! |
A lot of this is fairly old code, which we can shorten slightly by using arrow functions instead of "regular" functions.