Also cache "sub" ColorSpaces globally (PR 19583 follow-up) #19598
Conversation
Some ColorSpaces can reference other ColorSpaces, and since it's fairly common for many pages to use the same ColorSpaces (see e.g. `issue17061.pdf`) this can help reduce a lot of unnecessary re-parsing especially for e.g. `ICCBased` ColorSpaces.
By passing around common parameters, i.e. everything that's not the ColorSpace-data, in an object we can shorten this code a little bit.
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4eace002e1679dd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/891f51560eb12ed/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4eace002e1679dd/output.txt Total script time: 2.36 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/891f51560eb12ed/output.txt Total script time: 7.61 mins
|
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/207aef96eea2ea4/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ba60a2eb3e4f489/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ba60a2eb3e4f489/output.txt Total script time: 16.79 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/207aef96eea2ea4/output.txt Total script time: 30.47 mins
Image differences available at: http://54.193.163.58:8877/207aef96eea2ea4/reftest-analyzer.html#web=eq.log |
Some ColorSpaces can reference other ColorSpaces, and since it's fairly common for many pages to use the same ColorSpaces (see e.g.
issue17061.pdf) this can help reduce a lot of unnecessary re-parsing especially for e.g.ICCBasedColorSpaces.