Skip to content

Commit

Permalink
Remove engine-gecko now that it is empty
Browse files Browse the repository at this point in the history
  • Loading branch information
badboy committed Jan 9, 2025
1 parent b47f1d1 commit 4a2d1b7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 40 deletions.
13 changes: 0 additions & 13 deletions probe_scraper/glean_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,19 +139,6 @@ def check_for_duplicate_metrics(repositories, metrics_by_repo, emails):

duplicate_sources = {}
for k, v in metric_sources.items():
# Exempt cases when one of the sources is Geckoview Streaming to
# avoid false positive duplication accross app channels.
# Temporarily exempt cases when one of the sources is server compat library
# to avoid raising alarm for metrics defined in fxa's custom ping.
v = [
dep
for dep in v
if (
"engine-gecko" not in dep
and "glean-server-metrics-compat" not in dep
)
]

if len(v) > 1:
duplicate_sources[k] = v

Expand Down
27 changes: 0 additions & 27 deletions repositories.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,23 +93,6 @@ libraries:
variants:
- v1_name: sync
dependency_name: org.mozilla.appservices:syncmanager
- library_name: engine-gecko
description: GeckoView metrics
notification_emails:
- [email protected]
- [email protected]
- [email protected]
url: https://github.com/mozilla/gecko-dev
metrics_files: []
variants:
- v1_name: engine-gecko
branch: release
dependency_name: org.mozilla.components:browser-engine-gecko
- v1_name: engine-gecko-beta
branch: beta
dependency_name: org.mozilla.components:browser-engine-gecko-beta
- v1_name: engine-gecko-nightly
dependency_name: org.mozilla.components:browser-engine-gecko-nightly

- library_name: logins-store
description: >-
Expand Down Expand Up @@ -722,38 +705,28 @@ applications:
- v1_name: firefox-android-release
app_id: org.mozilla.firefox
app_channel: release
additional_dependencies:
- org.mozilla.components:browser-engine-gecko
description: >-
Release channel of Firefox for Android.
- v1_name: firefox-android-beta
app_id: org.mozilla.firefox_beta
app_channel: beta
additional_dependencies:
- org.mozilla.components:browser-engine-gecko-beta
description: >-
Beta channel of Firefox for Android.
- v1_name: fenix
app_id: org.mozilla.fenix
app_channel: nightly
additional_dependencies:
- org.mozilla.components:browser-engine-gecko-beta
description: >-
Nightly channel of Firefox for Android.
Prior to June 2020, this app_id was used for the beta channel
of Firefox Preview.
- v1_name: fenix-nightly
app_id: org.mozilla.fenix.nightly
app_channel: nightly
additional_dependencies:
- org.mozilla.components:browser-engine-gecko-nightly
description: >-
Nightly channel of Firefox Preview.
- v1_name: firefox-android-nightly
app_id: org.mozilla.fennec.aurora
app_channel: nightly
additional_dependencies:
- org.mozilla.components:browser-engine-gecko-beta
description: >-
Nightly channel of Firefox for Android users migrated to Fenix;
delisted in June 2020.
Expand Down

0 comments on commit 4a2d1b7

Please sign in to comment.