Fix #755: Import lambdas into this repo #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
force-pushed
the
755-cronjobs
branch
from
e9617c4 to
25c4b9f
Compare
alexcottner
reviewed
Feb 24, 2025
| authors = ["Contactless <postmaster@localhost>"] | ||
|
|
||
| [tool.poetry.dependencies] | ||
| python = ">=3.11, <3.14" |
There was a problem hiding this comment.
Nice, upgraded from the requirements files
alexcottner
approved these changes
Feb 24, 2025
|
Let's wait for https://github.com/mozilla-sre-deploy/deploy-remote-settings-cronjobs/pull/18 before doing this. I'll backport changes if we have to touch anything at https://github.com/mozilla-services/remote-settings-lambdas/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #755: Import lambdas into this repo
This will require some changes in the deploy repo. Instead of assuming that the lambdas container is built from the
Dockerfileat the root of themozilla-services/remote-settings-lambdasrepo, it will now have to be built from theCronjobs.Dockerfilefile of `mozilla/remote-settings repo.See also https://github.com/mozilla-sre-deploy/deploy-remote-settings-cronjobs/pull/17