Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scroll to Text Fragment #235

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Add Scroll to Text Fragment #235

merged 1 commit into from
Dec 23, 2019

Conversation

bzbarsky
Copy link
Contributor

@bzbarsky bzbarsky commented Dec 23, 2019 •
edited
Loading

Fixes #194

@bzbarsky bzbarsky force-pushed the scroll-to-text-fragment branch from 130258a to ea8cc78 Compare December 23, 2019 21:42
dbaron
dbaron reviewed Dec 23, 2019
View reviewed changes
Copy link
Contributor

@dbaron dbaron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is basically fine, except it would have been good to run ./activities.py sort first so it doesn't conflict with #236. It might also be worth referencing the positioned added in #236 in the details.

@bzbarsky bzbarsky force-pushed the scroll-to-text-fragment branch from ea8cc78 to 251788c Compare December 23, 2019 22:04
@dbaron dbaron merged commit 89efa7d into mozilla:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaron dbaron dbaron left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll To Text Fragment
2 participants
@bzbarsky @dbaron