Add user agent override list support. (fixes #488)

[bluemarvin]

No description provided.

[cvan]

this works well. many thanks for writing both this and the GV patch.

only question I have: how can we benchmark network load times before vs. after this UA Override code? how significant is the perf hit for both cache misses and hits?

[caseyyee]

It seems to all work for me (functional test only, will leave code up to others!)

[bluemarvin]

only question I have: how can we benchmark network load times before vs. after this UA Override code? how significant is the perf hit for both cache misses and hits?

@cvan The only way I know is to get system time before and after the call to lookupOverride() to see how long each call takes. I'm not sure how to make it any faster though. We probably want to improve in GV how the overrides are set and get it out of the JS layer but that would require a significant refactor and isn't going to happen soon.

[cvan]

this looks good to go! excellent work 👍

[bluemarvin]

@cvan, I think this is ready to land. Should I wait until you have time to update userAgentOverride.json? Or should that be a followup?

[cvan]

@cvan, I think this is ready to land. Should I wait until you have time to update userAgentOverride.json? Or should that be a followup?

to make which changes? you mean to add more exceptions?

[bluemarvin]

@cvan, I think this is ready to land. Should I wait until you have time to update userAgentOverride.json? Or should that be a followup?

to make which changes? you mean to add more exceptions?

Yeah, I wasn't sure if this was the complete file or not.

[cvan]

yep, that's the complete file - thanks for checking