This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Disable Media Control buttons for non-video sources #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyyee
suggested changes
Nov 21, 2018
There was a problem hiding this comment.
Media controls still show after viewing video.
-
Navigate to "Window and Screen" on:
https://mixedreality.mozilla.org/fxr-html-tests/index.html -
Click option 2: "window dimensions with fullscreen", enter Fullscreen. Note that media controls are grayed out. (this works properly)
-
Click option 3: "video.requestFullscreen()", enter Fullscreen, Note media controls are active.
-
Navigate back to option 2: enter Fullscreen, select VR mode, note media controls are present.
MortimerGoro
force-pushed
the
null_media_controls
branch
from
29eacfd
to
04ae264
Compare
|
The problem was that the medias were not cleaned after a page change 85c2cc3 |
|
Merging this. you can create a new issue if you find anything else. |
|
FWIW, looks fixed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #776