vd_lavc: don't hardware decode vc1 by default #15733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually we were already logging a message in this case, but it was only verbose. Bump it up to info if --hwdec-codecs is at the default value and we are trying to use hwdec since it is probably not obvious to users what is happening.
It's known to be broken on several drivers/hwdecs. hwdec for vc1 is probably not very useful in practice so just disable it by default. Closes mpv-player#15715.
|
Download the artifacts for this pull request: |
philipl
approved these changes
Jan 25, 2025
|
I can't find the IRC logs, but I already proposed lowering the level of the "Not trying to use hardware decoding" message and someone (CounterPillow?) said that it already was info before and was raised because people kept thinking that hardware decoding not being used was a bug, and that it would also get logged for codecs that don't support hardware decoding like images. |
|
previously: #12407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit based on the suggestion: #15715 (comment)