-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
input.conf: bind HOME and END #15856
Conversation
I'm not strictly against this, but intuitively it feels to me like home/end should apply to the current clip rather than to the playlist, and maybe with ctrl or shift it should apply to the playlist. @guidocella did raise up some valid counter arguments:
Any thoughts on what should home/end do as default bindings? |
I've always had HOME/END bound to seek operations (seek (-)32 relative-percent, so that you can jump by a third of the length of the current clip at a time), although I'll readily admit that I haven't used those bindings regularly in a long time. |
As I never uses chapters and just skip to next file in a playlist I think keys without ctrl or shift should apply to current clip. |
Changed to HOME seek 0 absolute |
Download the artifacts for this pull request: |
I use these bindings for editing video/audio |
DOCS/man/mpv.rst
Outdated
Seek to the beginning of the file. | ||
|
||
END | ||
Seek to 95% of the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like magic 95% seek. Either make it seek to the real end or not at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would you seek to the end, and how would that be useful? This at least lets you seek towards the end quickly, e.g. I've been pressing END + Page down to quickly seek to anime ending chapters which is convenient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is seeking to 95% useful? The same case but got to real and and stay there (depending on other mpv options).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just gave an example of how it's useful?? Seek to end would just be quit or playlist-next with the default options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
95% in 10 minute clip is quite different than in 3 h movie. For me END means end, not some 5%, but anyway. Not gonna argue that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the first thing we need is that END is meaningful, and we can probably agree that it's not meaningful with the default mpv options.
So the question is which value should be used instead.
Few options came up, among them 95%, 99%, someplace in between, or a fixed delta from the end, for instance 1 minute.
I don't think there's a perfect solution here, and between the imperfect options we can choose from, I think we should just pick one. I don't have a personal preference between them, but if someone does, then let's go with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to have this, I think some fixed delta from the end is the way to go. Like Kasper said, using a percent is going to be wildly different depending on the length of the clip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to END seek -60 absolute
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I would bind only HOME. If anything END could jump to last chapter or do nothing if there are no chapters. Any time related seek for END whether relative or absolute seems wrong to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed END
.
LGTM too. Good solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with these bindings.
No description provided.