mac/dialog: release all input keys when modal steals key input #15884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the proper initialFirstResponder variable
modal dialogs steal the key/mouse input and possibly eat corresponding key up events when opening via key binding. this leads to key sequence ends to not reported and key bindings not being triggered if no key up event was triggered after closing the modal.
4 tasks
|
Download the artifacts for this pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kasper93 a heads up, this might lead to some merge conflicts with your dialog branch. also the save function needs the panel delegate set too (eg
panel.delegate = self).modal dialogs steal the key/mouse input and possibly eat corresponding key up events when opening via key binding. this leads to key sequence ends to not reported and key bindings not being triggered if no key up event was triggered after closing the modal.