disc syntax cleanups/deprecations #15899
Merged
+29
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is allowed but it's pretty weird. You'd end up typing something like dvd:////dev/sr0 or cdda:///dev/sr0 (notice the differing amount of /). Why is this even useful? Just use the matching --cdda-device option. There's no need to have two ways to do the same thing here.
You probably wouldn't guess what this does from the name alone, but it actually selects a range of tracks to play. It's slightly different than using --start because it confines the range to just that track and you cannot seek before it. The functionality is useful, but you can accomplish exactly the same thing with --start and --end. Also the implementation of the cdda option is weird because starting from a track after 1 makes it impossible to seek before it. There's no reason to have this when using the core option is simply better and works fine.
|
Download the artifacts for this pull request: |
na-na-hi
reviewed
Feb 18, 2025
| @@ -0,0 +1 @@ | |||
| specifying an optical device after the schema for the `cdda://`, `dvd://` and `bd://` protocols is deprecated, use the appropriate option (`--cdda-device`) instead | |||
There was a problem hiding this comment.
I think some prefer after schema because it's less letters to type.
It's not exactly obvious and worth mentioning.
Dudemanguy
force-pushed
the
disc-syntax
branch
from
9bc914d to
8f3fdd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I like changing things.