osdep/w32_install: add install/uninstall options for Windows

[kasper93]

I deleted the branch by accident and it nuked the PR, which cannot be reopened for recreated branches. Old PR: #15904

[kasper93]

Open questions:

• Should --install be renamed to --register?

I think users are more familiar with install word. There were voices that install has to move binary somewhere else, but looking at definition https://www.merriam-webster.com/dictionary/install

to set up for use or service

it is exactly what it does.

• Should --install in fact move mpv.exe into user programs?
  I prefer keeping it portable, the --install / --uninstall command are not tied to installation itself. For example you can move binary, install again and it will work. There is no need to uninstall anything, before moving.

• Should archive-exts list be added to mpv's supported formats
  I don't see a reason why not. It is still user decision to select application to use. This is handled externally by Windows. Although I agree, mpv it likely not primary choice for archives, it's nice to have it suggested in "open with" drop-down.

Anything else?

EDIT:

One more

• Do we want icon for this mpv-install, mpv-uninstall thing?
  And if, so contributions welcome. It would be awkward to use the same icon as for mpv.

---

Most softwares' installer, main exec and uninstaller are detached. And not all sw use the same dir for main exec and uninstaller.

Yes we don't have dedicated installer, which drops dozen of files everywhere. My objective is to make this as clean and light as possible, while still making things work in Windows.

Some installers could detect the installed one and could even directly uninstall it.

The same as mpv, you can do mpv --uninstall from any mpv binary and it will work correctly. In fact while --install is handy to be in mpv, because it can be parametrized easily for used extensions, without creating whole another application or using installer for that. The --uninstall command is mostly portable. Though I still don't like the idea of dropping files in random places. But this is one of the questions above. If people want this, we can copy the .exe to programs...

Though I see no real issue, if someone uses mpv.exe and removes it, nothing bad happens... Worse case thay have stale entry in control panel, which will be pruned by windows. We can also completely skip uninstall entry in control panel if this is the main concern. But I still don't see why if user breaks it, it's mpv's fault.

mpv is the only special case I've meet that it could do three jobs by the same single file.

and if it's two files and you remove uninstall.bat what happens? mpv.exe is single binary, we really don't need full installer to handle it. Also mpc-hc, foobar2000, lav filters, 7zip all have in place installation. foobar2000 even does it on every start of application. madvr/lav filters have bat files, that lives along .dll, but it's still calls in the .dll regsvr. So if you remove them, well you no longer can uninstall.

[github-actions]

Download the artifacts for this pull request:

Windows

• mpv-i686-w64-mingw32
• mpv-x86_64-w64-mingw32
• mpv-x86_64-windows-msvc

macOS

• mpv-macos-13-intel
• mpv-macos-14-arm
• mpv-macos-15-arm

[avih]

Docs changes LGTM. Thanks.

I don't feel strongly about any of the open questions.

Moving the mpv binary would indeed make it a normal installer, but it's more work. I'd imagine there's a good reason that usually an installer application is used (inno setup etc), because it looks simple but I imagine there are many details to take care of - which personally I'm not familiar with.

I think registering mpv inplace is enough. Adding an actual installer would be fine too, but I don't think it's required.

Re the option name, I think the fact that it adds an uninstall entry at the control panel (which is a good thing) kind of makes us choose "install", for consistency. But "register" also a valid choice, because it is indeed a better description of the action.

Bottom line, either one would be OK IMO.

Re icon, not necessary IMO but it would be nicer to have one. I don't think mpv icon would be too bad, but also, there are enough free icons out there, and a generic cog icon or some such would do fine IMO. Or like the original PR did, pick an icon from an existing system file. Just ensure/test that it still works (does the registration/whatever) even if the file is missing.

[hooke007]

I vote for --register. Not a serious reason: Making it looks more different with mpv-install.bat.

[kasper93]

I vote for --register.

Ok, we can go with --register and --unregister, while install/uninstall term might be more familiar to regular joe when manipulation software. Also note I won't use --deregister, contrary to what might seem more fighting according to https://english.stackexchange.com/questions/25931/unregister-vs-deregister, but the --unregister feels nicer and is what also Windows itself used for operations like that.

(software like madvr / lav filters, were for years using install, hance why this was my first choice, but no matter)

Moving the mpv binary would indeed make it a normal installer, but it's more work. I'd imagine there's a good reason that usually an installer application is used (inno setup etc), because it looks simple but I imagine there are many details to take care of - which personally I'm not familiar with.

After consideration this is not a job for this command. It looks simple if you forget that normally you have more than single executable to package. Creating installer is still possible and valid on top of this registration command. Note that it can be self-expanding archive, which would serve similar purpose. The point is if you have to handle more files, like additional .dlls, icons, whatever. It makes only sense to have separate packaging solution.

But we need to distinguish what this PR does, which is registration of media plater from packaging the mpv into self-extracting or self-installing single-click solution.

Also like I was hinting on IRC, once you start moving things, you end up looking like malware https://devblogs.microsoft.com/oldnewthing/20230911-00/?p=108749 :) That's of course a joke and not applicable to mpv, but if you want to uninstall the uninstall.exe itself, it's always funny exercise.

Bonus chatter: If we were using cmake, we would have all sort of packaging solutions for free with cpack that integrates with install command. Meson doesn't have this convenience.

Re icon, not necessary IMO but it would be nicer to have one. I don't think mpv icon would be too bad, but also, there are enough free icons out there, and a generic cog icon or some such would do fine IMO. Or like the original PR did, pick an icon from an existing system file. Just ensure/test that it still works (does the registration/whatever) even if the file is missing.

This is in fact detail. I went back and forth few times, changing this install/uninstall helpers from showing command line window and not. And I settled to show it, which means, it won't have manifest or icon. But that's fine... it shows little tiny command line icon.

[kasper93]

I vote for --register. Not a serious reason: Making it looks more different with mpv-install.bat.

Changed everything to register. If feels awkward at places, but I will get used to it.

Perhaps the documentation should be updated to indicate that installation is required to make STMC show the icon and program name.

Added.

Please consider changing the first sentence to something along those lines, if you too think it can make it clearer.

Added.

---

Any more suggestions? I'm not sure what would be useful to add/change here.

[avih]

Please consider changing the first sentence to something along those lines, if you too think it can make it clearer.

Added.

Thanks.

Apologies for wasting both out time due to me not reading the whole section carefully before embarking on a discussion.