Skip to content

Commit

Permalink
Remove DynaLoader
Browse files Browse the repository at this point in the history
* lib/Locale/Po4a/Man.pm, lib/Locale/Po4a/Po.pm,
lib/Locale/Po4a/TransTractor.pm: Remove DynaLoader from the is-a
relationships.  DynaLoader was introduced in
0a4e526 for performance reasons.
However the XS was removed in
dbbc6d2, about 4 years ago.
  • Loading branch information
gemmaro committed Oct 8, 2024
1 parent 7658dc6 commit 1f433b8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
3 changes: 1 addition & 2 deletions lib/Locale/Po4a/Man.pm
Original file line number Diff line number Diff line change
Expand Up @@ -393,15 +393,14 @@ under the terms of GPL v2.0 or later (see the COPYING file).
=cut

package Locale::Po4a::Man;
use DynaLoader;

use 5.16.0;
use strict;
use warnings;

require Exporter;
use vars qw(@ISA @EXPORT);
@ISA = qw(Locale::Po4a::TransTractor DynaLoader);
@ISA = qw(Locale::Po4a::TransTractor);
@EXPORT = qw(); # new initialize);

# Try to use a C extension if present.
Expand Down
3 changes: 1 addition & 2 deletions lib/Locale/Po4a/Po.pm
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,12 @@ use IO::File;
require Exporter;

package Locale::Po4a::Po;
use DynaLoader;

use Locale::Po4a::Common qw(wrap_msg wrap_mod wrap_ref_mod dgettext);

use subs qw(makespace);
use vars qw(@ISA @EXPORT_OK);
@ISA = qw(Exporter DynaLoader);
@ISA = qw(Exporter);
@EXPORT = qw(%debug);
@EXPORT_OK = qw(&move_po_if_needed);

Expand Down
4 changes: 1 addition & 3 deletions lib/Locale/Po4a/TransTractor.pm
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
require Exporter;

package Locale::Po4a::TransTractor;
use DynaLoader;

sub import { }

Expand All @@ -12,9 +11,8 @@ use strict;
use warnings;

use subs qw(makespace);
use vars qw($VERSION @ISA @EXPORT);
use vars qw($VERSION @EXPORT);
$VERSION = "0.74-alpha";
@ISA = qw(DynaLoader);
@EXPORT = qw(new process translate
read write readpo writepo
getpoout setpoout get_in_charset get_out_charset handle_yaml);
Expand Down

0 comments on commit 1f433b8

Please sign in to comment.