[C++] Fix clang -Wnewline-eof warning (google#7711)

* Fix clang -Wnewline-eof warning

* Enable -Wnewline-eof warning

Co-authored-by: Derek Bailey <[email protected]>

CMakeLists.txt

@@ -426,6 +426,7 @@ else()
 
       # This isn't working for some reason: $<$<CXX_COMPILER_ID:CLANG>:
       $<$<BOOL:${IS_CLANG}>:
+        -Wnewline-eof
         -Wno-unknown-warning-option
         -Wmissing-declarations
         -Wzero-as-null-pointer-constant

include/flatbuffers/allocator.h

@@ -65,4 +65,4 @@ class Allocator {
 
 }  // namespace flatbuffers
 
-#endif  // FLATBUFFERS_ALLOCATOR_H_
+#endif  // FLATBUFFERS_ALLOCATOR_H_

include/flatbuffers/buffer_ref.h

@@ -50,4 +50,4 @@ template<typename T> struct BufferRef : BufferRefBase {
 
 }  // namespace flatbuffers
 
-#endif  // FLATBUFFERS_BUFFER_REF_H_
+#endif  // FLATBUFFERS_BUFFER_REF_H_

include/flatbuffers/default_allocator.h

@@ -61,4 +61,4 @@ inline uint8_t *ReallocateDownward(Allocator *allocator, uint8_t *old_p,
 
 }  // namespace flatbuffers
 
-#endif  // FLATBUFFERS_DEFAULT_ALLOCATOR_H_
+#endif  // FLATBUFFERS_DEFAULT_ALLOCATOR_H_

include/flatbuffers/string.h

@@ -61,4 +61,4 @@ static inline flatbuffers::string_view GetStringView(const String *str) {
 
 }  // namespace flatbuffers
 
-#endif  // FLATBUFFERS_STRING_H_
+#endif  // FLATBUFFERS_STRING_H_

include/flatbuffers/struct.h

@@ -50,4 +50,4 @@ class Struct FLATBUFFERS_FINAL_CLASS {
 
 }  // namespace flatbuffers
 
-#endif  // FLATBUFFERS_STRUCT_H_
+#endif  // FLATBUFFERS_STRUCT_H_

src/bfbs_gen_lua.cpp

@@ -630,4 +630,4 @@ std::unique_ptr<BfbsGenerator> NewLuaBfbsGenerator(
   return std::unique_ptr<LuaBfbsGenerator>(new LuaBfbsGenerator(flatc_version));
 }
 
-}  // namespace flatbuffers
+}  // namespace flatbuffers

src/bfbs_gen_lua.h

@@ -30,4 +30,4 @@ std::unique_ptr<BfbsGenerator> NewLuaBfbsGenerator(
 
 }  // namespace flatbuffers
 
-#endif  // FLATBUFFERS_BFBS_GEN_LUA_H_
+#endif  // FLATBUFFERS_BFBS_GEN_LUA_H_

src/bfbs_namer.h

@@ -48,4 +48,4 @@ class BfbsNamer : public Namer {
 
 }  // namespace flatbuffers
 
-#endif  // FLATBUFFERS_BFBS_NAMER
+#endif  // FLATBUFFERS_BFBS_NAMER

src/binary_annotator.h

@@ -389,4 +389,4 @@ class BinaryAnnotator {
 
 }  // namespace flatbuffers
 
-#endif  // FLATBUFFERS_BINARY_ANNOTATOR_H_
+#endif  // FLATBUFFERS_BINARY_ANNOTATOR_H_

tests/flexbuffers_test.h

@@ -13,4 +13,4 @@ void ParseFlexbuffersFromJsonWithNullTest();
 }  // namespace tests
 }  // namespace flatbuffers
 
-#endif  // TESTS_FLEXBUFFERS_TEST_H
+#endif  // TESTS_FLEXBUFFERS_TEST_H

tests/json_test.cpp

@@ -171,4 +171,4 @@ void JsonUnsortedArrayTest() {
 }
 
 }  // namespace tests
-}  // namespace flatbuffers
+}  // namespace flatbuffers

tests/json_test.h

@@ -15,4 +15,4 @@ void JsonUnsortedArrayTest();
 }  // namespace tests
 }  // namespace flatbuffers
 
-#endif
+#endif

tests/monster_test.h

@@ -35,4 +35,4 @@ void UnPackTo(const uint8_t *flatbuf);
 }  // namespace tests
 }  // namespace flatbuffers
 
-#endif
+#endif

tests/optional_scalars_test.cpp

@@ -98,4 +98,4 @@ void OptionalScalarsTest() {
 }
 
   }
-}
+}

tests/parser_test.h

@@ -30,4 +30,4 @@ void FieldIdentifierTest();
 }  // namespace tests
 }  // namespace flatbuffers
 
-#endif  // TESTS_PARSER_TEST_H
+#endif  // TESTS_PARSER_TEST_H

tests/proto_test.h

@@ -15,4 +15,4 @@ void ParseProtoBufAsciiTest();
 }  // namespace tests
 }  // namespace flatbuffers
 
-#endif
+#endif