-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for IPv6 (1/x) #275
Conversation
You can find additional patches in the |
Many thanks. I’ll provide feedback by tomorrow night. |
Thanks for starting the IPv6 integration. Looks like you have focused on the changes necessary on the ipv6-server branch to start accepting incoming SPA packets via IPv6. As you noted somewhere, this does not change the SPA packet format, but more about the mechanics of acquiring the packet data. Have you also started looking at what would be required to encode IPv6 addresses within the SPA packets themselves? I.e. changing the access request field for example? I think it would be a good idea to also start bootstrapping the test suite to handle IPv6. At least, I have found this to be a good way to work on major features. Maybe what I should do is start helping with the test suite in this regard. |
That's right, with this branch SPA packets can be received via IPv6. I saw that IPv4 addresses are base64-encoded in there, so I think it will be possible to use the regular IPv6 notation there (abc::123.port etc) and simply check for valid IPv4 or IPv6 information there - therefore not affecting compatibility with older IPv4-only services. |
On
On
Also, the IPv6 tests took much more time, but I ran them first and had activity in other VMs, so it is not necessarily reflecting performance degradation. |
21ab445
to
8d0fb60
Compare
This alone should allow interacting with IPv4 firewalling rules over IPv6, for these two protocols.
This will allow porting the raw ICMP code to IPv6.
The remote code seems to be independent from the fwknop project though. Until it will be capable to return IPv6 addresses, in itself this will remain irrelevant for the purpose of adding IPv6 support to fwknop. On another hand, it does help us introduce definitions and update headers to actually support IPv6.
I believe it should be more portable this way, since AF_INET is required to be present in <sys/socket.h> in POSIX.
This should help with portability for the protocol family eventually.
This should help with portability for the protocol family eventually.
This should eventually help with portability to IPv6.
This is still using IPv4 by default for the moment.
I just (rebased on |
This is currently "--ipv6", or "-6" for short.
See #285 for feature-complete IPv6 support on the client and server sides. |
This group of commits of a series attempting to bring IPv6 support to fwknop (see #1). It notably allows IPv6 communication over TCP or UDP, with or without PCAP, for both the server and the client. At this stage, only IPv4 firewalling rules can be applied.
This currently requires
SOURCE ANY
to be set in the configuration.