Separate out the distance calculations #444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebmason
force-pushed
the
distance
branch
7 times, most recently
from
7c40b93 to
4c1a6af
Compare
|
This fixes #447 |
zebmason
requested review from
dlaydon,
gnedjati,
igfoo,
matt-gretton-dann,
NeilFerguson,
weshinsley and
Z80coder
as code owners
zebmason
force-pushed
the
distance
branch
2 times, most recently
from
400d07c to
8246d87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing branching this may make the calculations faster (branch prediction may disagree). Can add in unit tests.
@weshinsley Let me know if you are interested and I'll do further development.