Release 0.1.17 #202
Merged
Release 0.1.17 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of how R assigns names to stack frames, all processes in a typical individual simulation would end up being called `p`. This makes it difficult to interpret profiling results. R uses the name of the variable the called function is bound to. By dynamically creating a variable with a chosen name and using `eval` to execute that variable, we can get the stack frame to show up with any desired name. This uses this trick to allow the list of processes to be given names, and these names are used in the calls.
In addition to a vector of numerical indices and another bitset, the filter_bitset now accepts a vector of logicals (ie. booleans). Each set bit of the bitset is included in the return value only if the corresponding value in the logical vector is TRUE. Given `v` a logical vector, `filter_bitset(b, v)` is equivalent to the already supported `filter_bitset(v, which(v))` but is more performant. The new semantics also align with subsetting of R vectors, which similarly supports either a vector of indices or vector of logicals.
The variable stores the number of bits per word and is used throughout the implementation to split a position into a word index and bit position in the word. The value can be determined statically from the size of the template parameter and does not need to be stored as a field. Keeping it as a `constexpr` value allows the compiler to optimize operations that use it. In particular, since the value is always a power of two, any multiplication, division, and modulo operations by this value, which are quite common, can be turned into bit shifts or masks by a constant. The performance impact of this change is quite small, but measurable, at around 2% for a 1M malariasimulation run, with no downside.
Make num_bits a constant expression.
This copies the value from one bitset to another one.
giovannic
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.