Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #146, by renaming the location pull commands:
orderly_location_pull_metadata
becomesorderly_location_metadata_fetch
orderly_location_pull_packet
becomesorderly_location_pull
There's a bit of deprecation support, but I think that won't be needed for long.
Two small issues arising:
metadata_fetch
orfetch_metadata
?pull_metadata
argument now does not make much sense; fixing this is a little more disruptive but we are uniquely placed to fix it after Ergonomic improvements for querying, part 2 #187 as people are updating anyway