Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in tasty module #154

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

bradsherman
Copy link
Contributor

I noticed this while trying to run neotest haskell in a stack project with tasty tests. Once I fixed this typo, I was able to do things like lua require('neotest').run.run() and have the test run. Without this change, it would fail with an error saying Cannot run tests for configured build tools: stack.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏
Weird that CI didn't catch this.

@mrcjkb mrcjkb enabled auto-merge (squash) April 5, 2024 21:12
@mrcjkb mrcjkb merged commit 8c817aa into mrcjkb:master Apr 5, 2024
5 of 6 checks passed
@mrcjkb
Copy link
Owner

mrcjkb commented Apr 5, 2024

@all-contributors please add @bradsherman for code

Copy link
Contributor

@mrcjkb

I've put up a pull request to add @bradsherman! 🎉

@mrcjkb
Copy link
Owner

mrcjkb commented Apr 5, 2024

I'm out right now, but I'll push a new tag tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants