Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config/dap): use absolute path to debug adapter if available #679

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix(config/dap): use absolute path to debug adapter if available #679

merged 1 commit into from
Feb 3, 2025

Conversation

BirdeeHub
Copy link
Contributor

Addresses

#678

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

mrcjkb
mrcjkb requested changes Feb 3, 2025
View reviewed changes
lua/rustaceanvim/config/internal.lua Outdated Show resolved Hide resolved
lua/rustaceanvim/config/internal.lua Outdated Show resolved Hide resolved
@mrcjkb mrcjkb changed the title fix(aDAPters): make DAP use absolute path from vim.fn.exepath fix(config/dap): use absolute path to debug adapter if available Feb 3, 2025
@mrcjkb mrcjkb linked an issue Feb 3, 2025 that may be closed by this pull request
LLDB adapter setup issue #678
Closed
9 tasks
@BirdeeHub
Copy link
Contributor Author

should I squash these now or is this alright

@BirdeeHub BirdeeHub requested a review from mrcjkb February 3, 2025 16:39
@mrcjkb
fix(config/dap): use absolute path to debug adapter if available
09d1866 
Update lua/rustaceanvim/config/internal.lua

Co-authored-by: Marc Jakobi <[email protected]>

Update lua/rustaceanvim/config/internal.lua

Co-authored-by: Marc Jakobi <[email protected]>
@BirdeeHub
Copy link
Contributor Author

BirdeeHub commented Feb 3, 2025 •
edited
Loading

I squashed them and fixed the commit message

mrcjkb
mrcjkb approved these changes Feb 3, 2025
View reviewed changes
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@mrcjkb mrcjkb merged commit 96f6ac9 into mrcjkb:master Feb 3, 2025
5 checks passed
@mrcjkb mrcjkb mentioned this pull request Feb 3, 2025
Merged
@BirdeeHub
Copy link
Contributor Author

I kinda liked the pun in my original message but your message was more descriptive haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcjkb mrcjkb mrcjkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LLDB adapter setup issue
2 participants
@BirdeeHub @mrcjkb