Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WGSLNodeBuilder: Improve NearestFilter support #29910

Merged
merged 1 commit into from
Nov 16, 2024
Merged

WGSLNodeBuilder: Improve NearestFilter support #29910

merged 1 commit into from
Nov 16, 2024
+43 −29

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Nov 16, 2024 •
edited
Loading

Related issue: Closes #29852

Description

This uses textureLoad when both wrap* use NearestFilter, as is the case with DepthTexture.

It should fix the WebGPU warnings: #29852 (comment)

@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.37
79.06		 339.37
79.06		 +0 B
+0 B
WebGPU 478.22
132.63		 478.09
132.59		 -126 B
-41 B
WebGPU Nodes 477.68
132.51		 477.56
132.47		 -126 B
-43 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.82
112.02		 464.82
112.02		 +0 B
+0 B
WebGPU 546.95
148.2		 546.82
148.15		 -128 B
-45 B
WebGPU Nodes 502.83
137.91		 502.7
137.86		 -128 B
-44 B

@sunag sunag marked this pull request as ready for review November 16, 2024 20:36
@sunag sunag merged commit 9f289d8 into mrdoob:dev Nov 16, 2024
12 checks passed
@sunag sunag deleted the dev-nearest-filter branch November 16, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebGPURenderer: Update for depth texture sampling restrictions
1 participant
@sunag