SelectionHelper: ensure DOM cleanup #30473
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Feb 6, 2025
| @@ -59,6 +59,8 @@ class SelectionHelper { | |||
| this.renderer.domElement.removeEventListener( 'pointermove', this.onPointerMove ); | |||
| this.renderer.domElement.removeEventListener( 'pointerup', this.onPointerUp ); | |||
|
|
|||
| this.element.remove(); // in case disposal happens while dragging | |||
There was a problem hiding this comment.
Do you mind changing line 98 from:
this.element.parentElement.removeChild( this.element );to
this.element.remove();
as well? This style is a lot cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure DOM is cleaned up in case
SelectionHelper.dispose()is called during an incomplete dragging operation.Example scenario: if a view changes to another view and the selection should no longer apply, we don't want the selection rectangle to remain leaked on screen.
This contribution is funded by Lume (3D HTML framework)