refactor(state): made const

ms0g · Sep 18, 2024 · d6fcfb8 · d6fcfb8
1 parent 3bf6cc8
commit d6fcfb8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/world/states.hpp b/src/world/states.hpp
@@ -5,7 +5,7 @@
 
 namespace state {
 
-static std::vector<glm::vec3> cube = {
+static const std::vector<glm::vec3> cube = {
         {0.0f, -1.0f, 0.0f},
         {1.0f, -1.0f, 0.0f},
         {0.0f, -1.0f, 1.0f},
@@ -17,7 +17,7 @@ static std::vector<glm::vec3> cube = {
         {1.0f, 0.0f,  1.0f},
 };
 
-static std::vector<glm::vec3> oscCube = {
+static const std::vector<glm::vec3> oscCube = {
         {0.0f, 0.0f,  0.0f},
         {1.0f, 0.0f,  0.0f},
         {2.0f, 0.0f,  0.0f},

diff --git a/src/world/world.cpp b/src/world/world.cpp
@@ -65,9 +65,9 @@ void World::reset() {
     setState(mCurrentState);
 }
 
-void World::setState(std::vector<glm::vec3>& state) {
+void World::setState(const std::vector<glm::vec3>& state) {
     if (mCurrentState != state)
-        mCurrentState = std::move(state);
+        mCurrentState = state;
 
     for (auto& pos: mCurrentState) {
         mAliveCells.emplace(key::createFromPosition(pos), Cell{pos});

diff --git a/src/world/world.h b/src/world/world.h
@@ -28,7 +28,7 @@ class World {
 
     void reset();
 
-    void setState(std::vector<glm::vec3>& state);
+    void setState(const std::vector<glm::vec3>& state);
 
     void draw(glm::mat4 view, glm::mat4 projection);