Support for Unix Domain Socket

[hvishwanath]

Hi

I have forked the base repo and added support for Unix domain sockets. My main objective was as less intrusion as possible in the base code, and come up with something which can be 'plug and played'.

I have created a new transport builder (transport->uds.py) and a new address object msgpackrps->udsaddress.py. I have some examples demonstrating how to use UDS instead of tcp/ip sockets for msgpack rpc. Please review my repository and let me know if you are okay with merging these changes.

[hvishwanath]

Please ignore multiple comments reading the same content. Its a goofup with eclipse and Egit.

[repeatedly]

In this weekend, I will check this pull request.

[hvishwanath]

Thanks. Let me know if you need any changes.

[repeatedly]

I have serveral comments:

• Author comment in each file.

Please remove these comments on top of each file.
It is not msgpack-rpc-python style.

• README

Please move USD usage to Example section, not top.

• UDSAddress

UDSADdress is not common name.
LocalAddress is better and its class should be in msgpackrpc.address module.

• Test and sample code can't run on Python 3.

Please fix these bugs.

• Document style

See following example.

# OK
"""\
Foo
Bar
"""
# NG
"""Foo
Bar"""

Please apply above changes.

[hvishwanath]

Thanks for your review. Will update and get back.
On Apr 21, 2013 2:06 PM, "Masahiro Nakagawa" [email protected]
wrote:

I have serveral comments:

• Author comment in each file.

Please remove these comments on top of each file.
It is not msgpack-rpc-python style.

• README

Please move USD usage to Example section, not top.

• UDSAddress

UDSADdress is not common name.
LocalAddress is better and its class should be in msgpackrpc.address
module.

• Test and sample code can't run on Python 3.

Please fix these bugs.

• Document style

See following example.

OK"""\FooBar"""

NG"""HogeBar"""

Please apply above changes.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-16717813
.

[OrangeTux]

Well, any chance that this will be merged?

[hvishwanath]

Been a long time! I didn't think people would like to use unix domain
sockets with msgpackrpc, hence never got to updating the pull request. Will
get to it shortly.

Regards,
Harish

On Sat, Feb 14, 2015 at 6:31 PM, Auke Willem Oosterhoff <
[email protected]> wrote:

Well, any chance that this will be merged?

—
Reply to this email directly or view it on GitHub
#1 (comment)
.

[mmontone]

What happened with this merge? I would like to use it! :)

[repeatedly]

This patch doesn't apply my reviews so I can't merge.
If you want to use this feature, apply the patch by your hand.