erlangen_nuernberg: Improvements, add missing canteens #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxEtMoritz
commented
Jun 7, 2023
MaxEtMoritz
commented
- Update allergen list
- Change text "undefinierte Chemikalie" to "undefiniertes Allergen" (having undefined chemicals inside your meal reads a bit scary to me 😅)
- Update canteen list to include all currently available canteens of Studentenwerk (also the ones that don't have data in the XML file at the moment)
- Add parsing of nutritional facts (Energy, Fat, Carbon Hydrates etc.)
- Fix removal of allergen info from title: Allergen brackets have spaces around them. Removing just the brackets leads to double spaces in title or a space at the end. Removed one space per allergen bracket to fix that.
- Added missing allergens, Pictograms - change 'Chemikalie' to 'Allergen' (Chemical sound way too toxic for food)
add missing canteens where the XML files are present on server even those where these files are currently empty, just in case...
Allergic info has a space that leads to two spaces inside the meal title or spaces at the end.
seems like i forgot about that one on my last update...
Nice that this data is available, so why not add it as a note?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.