Aachen refactor #73
Closed
Aachen refactor #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 14, 2018 11:23
The regression tests that were in the package are now factored out of it.
added 15 commits
March 4, 2018 21:33
# Conflicts: # setup.py
added 12 commits
April 6, 2019 16:57
# Conflicts: # parser_tests/aachen/academica/snapshot-result.xml # parser_tests/aachen/academica/snapshot-website.json # setup.py
|
Closed because #71 was closed. I will fix the issues that this PR addresses in a separate rewrite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Aachener parser using OpenMensa model from #71.
It is based on both the snapshot tests (#96) and the model (#71) branches. Both of these should be merged before this PR.
Fixes