fix(oneOf): identify Nullable type returned from oneOf method #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is incomplete, as the ts-expect-error tests are failing in one-to-one test files for create and update. My intention here is for the return value of oneOf to default to
OneOf<ModelType, false>, and to beOneOf<ModelType, true>if you pass{ nullable: true }. However, the types I've added seem to not be specific enough, as the default is justOneOf<ModelType, boolean>whatever you set. @kettanaito are you able to provide some guidance? If not, I'll try and come back to this another time!