make_tree_writable: handle junctions and add tests #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As found out here, os.walk() by default follows junctions, which we don't want and can even lead to loops: msys2#101 (comment) Integrate the workaround mentioned in the CPython bug report: python/cpython#67596 (comment) Since this is Python 3.12+ only and we still support 3.10 make it optional though. This also adds tests, which uncovered some other minor issues: It was not chmoding top-down, which meant that os.walk would skip things if there were no read permissions. So chmod before os.walk() lists the dir.
|
Nice - this won't unbreak the runner until |
|
Since that function came from meson, perhaps they'd be interested in your fixes too? |
From what I see it's used there for directories meson creates itself, so unlikely they will have junctions I think. |
jeremyd2019
approved these changes
Jan 10, 2025
jeremyd2019
reviewed
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found out here, os.walk() by default follows junctions, which we don't want and can even lead to loops:
#101 (comment)
Integrate the workaround mentioned in the CPython bug report: python/cpython#67596 (comment) Since this is Python 3.12+ only and we still support 3.10 make it optional though.
This also adds tests, which uncovered some other minor issues: It was not chmoding top-down, which meant that os.walk would skip things if there were no read permissions. So chmod before os.walk() lists the dir.