-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make pipeworks Game agnostic #16
Conversation
I have https://github.com/sfence/pipeworks/tree/sfence_hades_revisited , so You can inspire by it, or I can add Hades support after code will be prepared for it. |
But for hades revisited support it should be kept in mind, that later, to not break main Hades ideas, it can be required to disable nodes like spigot, fountainhead. |
some of these recipes assume mesecons to be present, so I am unsure what the best way is to handle these crafts. I could just leave them for now? edit: deployer, dispenser, flow sensor, nodebreaker, |
Messecons is part of MineClone game and is available for Hades Revisited too (same item names, different textures). |
ill just make everything but mesecons game agnostic, and a game can add aliases if they desire |
Noticed a lot of mixed spaces/tabs indentation in changed and added content. Also in my opinion, if changing indentation, it is better to fix only changed/added and add another PR if changing formatting for everything, there's similar inconsistent indentation with old stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, did not test...
Indentation is still messed up but that's more "would be nice"-thing than "has to be resolved"-thing.
todo:
direct support for the following games
related issues: mt-mods/technic#214
maybe interesting to @sfence @BuckarooBanzay