Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pipeworks Game agnostic #16

Merged
merged 16 commits into from
Mar 15, 2022
Merged

make pipeworks Game agnostic #16

merged 16 commits into from
Mar 15, 2022

Conversation

wsor4035
Copy link
Contributor

@wsor4035 wsor4035 commented Mar 6, 2022

todo:

  • make it boot
  • make water pipes workoutside mtg
  • sounds
  • crafts
  • digging groups

direct support for the following games

  • mtg
  • farlands reloaded
  • mineclon*s
  • hades

related issues: mt-mods/technic#214

maybe interesting to @sfence @BuckarooBanzay

@wsor4035 wsor4035 marked this pull request as draft March 6, 2022 02:20
@wsor4035 wsor4035 added the enhancement New feature or request label Mar 6, 2022
@sfence
Copy link
Contributor

sfence commented Mar 6, 2022

I have https://github.com/sfence/pipeworks/tree/sfence_hades_revisited , so You can inspire by it, or I can add Hades support after code will be prepared for it.

@sfence
Copy link
Contributor

sfence commented Mar 6, 2022

But for hades revisited support it should be kept in mind, that later, to not break main Hades ideas, it can be required to disable nodes like spigot, fountainhead.

@wsor4035
Copy link
Contributor Author

wsor4035 commented Mar 12, 2022

some of these recipes assume mesecons to be present, so I am unsure what the best way is to handle these crafts. I could just leave them for now?

edit: deployer, dispenser, flow sensor, nodebreaker,

@sfence
Copy link
Contributor

sfence commented Mar 12, 2022

some of these recipes assume mesecons to be present, so I am unsure what the best way is to handle these crafts. I could just leave them for now?

edit: deployer, dispenser, flow sensor, nodebreaker,

Messecons is part of MineClone game and is available for Hades Revisited too (same item names, different textures).
It looks like Mineclone uses same name for messecon wire too.

@wsor4035
Copy link
Contributor Author

ill just make everything but mesecons game agnostic, and a game can add aliases if they desire

@wsor4035 wsor4035 marked this pull request as ready for review March 12, 2022 21:33
@S-S-X
Copy link
Member

S-S-X commented Mar 13, 2022

Noticed a lot of mixed spaces/tabs indentation in changed and added content.
Did not mention specific lines because it seems that most tables has inconsistent indentation.

Also in my opinion, if changing indentation, it is better to fix only changed/added and add another PR if changing formatting for everything, there's similar inconsistent indentation with old stuff.
If that's too hard then could as well ignore this here and do another PR just for formatting indentation.

@wsor4035 wsor4035 requested a review from S-S-X March 13, 2022 23:51
Copy link
Member

@S-S-X S-S-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, did not test...
Indentation is still messed up but that's more "would be nice"-thing than "has to be resolved"-thing.

@wsor4035 wsor4035 merged commit 5aa0501 into master Mar 15, 2022
@OgelGames OgelGames deleted the game_agnostic branch January 14, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants