Refactor base machine production loop #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuckarooBanzay
approved these changes
Feb 6, 2025
| if powered then | ||
| meta:set_int("src_time", meta:get_int("src_time") + round(def.speed*10)) | ||
| src_time = src_time + math.floor(def.speed * 10 + 0.5) |
There was a problem hiding this comment.
(just fyi, not really an issue here) i tried "inlining" some of the builtin functions and got a few percent more performance out of it if they are called often (for example here: https://github.com/BuckarooBanzay/mapsync/blob/master/encoding.lua#L1)
There was a problem hiding this comment.
Yeah, thought that for a moment too when I removed round(n) function but most of time this loop is executed something like twice or so unless someone add some extreme def.speed machine. Of course this times number of active machine in world but even then would still be very low.
I guess that could even be done later like for everything at once and make it kinda like a style rule rather than based on sometimes questionable benefit.
I did actually think a bit about optimizations too: this probably could be rewritten to grab all ingredients at once, calculate iterations beforehand, process recipes directly and modify inventories only once. (through I'm not gonna go there just yet 😅)
Click for detailed source code test coverage reportTest coverage report for Technic CNC 87.49% in 11/14 files:Test coverage report for technic chests 44.99% in 6/6 files:Test coverage report for technic 67.06% in 97/98 files:Raw test runner output for geeks:CNC: Chests: Technic: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit of fairly simple refactoring to make it a bit cleaner and while at it also reduce unnecessary things done in (potential) loop.