EUC-JISX0213の文字列の読み込みをDataから行うようにする #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtgto
commented
Mar 31, 2024
| return try String(contentsOf: url, encoding: .japaneseEUC) | ||
| } catch { | ||
| return try url.eucJis2004String() | ||
| } |
There was a problem hiding this comment.
macOS標準のデコードのフォールバックでやる必要ももうないだろうと思ったので、EUC-JPのときは最初からiconvでデコードします。
mtgto
force-pushed
the
euc-jis-2004-data-extension
branch
from
f23a27d to
6deafa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#82 で行ったlibiconvによるEUC-JISX0213の読み込みの処理はURLのextensionとして実装しました。
skkservへの接続対応で、XPCでもEUC-JISX0213形式のデコードがやりたいため、URLではなくDataのextensionとして実装します。