Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Merge if you want #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Merge if you want #1

wants to merge 4 commits into from

Conversation

ntwrkguru
Copy link

Works fine for me.

  • Merged jupyter/base-notebook Dockerfile as opposed to calling it as a base image
  • Resolved permissions for Ansible

mtucker502
mtucker502 reviewed Mar 14, 2017
View reviewed changes
Copy link
Owner

@mtucker502 mtucker502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why merge back with the original base-notebook rather than "FROM jupyter/base-notebook"?

@ntwrkguru
Copy link
Author

It's cleaner and uses less layers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtucker502 mtucker502 mtucker502 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntwrkguru @mtucker502