New version #1
New version #1
Conversation
Change server settings from settings page to driver pairing wizard to be able to support multiple servers Store server settings in it's devices settings Remove app settings page Remove unnecessary code Add next, previous and seek action cards Add Homey modules for added, deleted, renamed Up app version number Change readme with to do list and changed settings First try on mobile card (not working yet!)
Resolve lint errors Add mobile card item for play and stop First attempt to add meta data to mobile card
…rvers Added Javascript doc Code cleanup First check if device is online before making a call to server Added checks to see if server is giving a response Add code to set device online/offline in Homey Get and store extra device data when pairing Added Homey card for repeat and shuffle (Homey has a bug in mobile card see here https://github.com/athombv/homey/issues/842) Cleaned node modules from tests and examples Added repeat and shuffle to squeeze node module
|
Hi @Inversion-NL. When you're submitting pull requests can you please separate them into individual requests that address specific functionalities. Having them all in a single pull request makes it a really big job to review and delays acceptance of the pull request as a whole. For example, if your change to update to Homey 2.0 is just, say, 50 lines then I can review that quickly and get it merged for people to use. If those 50 lines are in a pull request with 500 other lines to add various other functionalities then I have to review all 550 lines before I can merge the change that upgrades the app to Homey 2.0. If instead you have, for example, a PR which just updates the app for Homey 2. Then another that adds additional flow cards. Another that adds auto-discovery etc. It means that I can review a small subset of the code and get that merged to master more quickly. You can do it by creating branches in your local github repository and raising a pull request for each subset of functionality. Does that make sense? |
|
But all had to be changed to have it working again.
Op wo 18 sep. 2019 10:58 schreef Mark Tudor <[email protected]>:
… Hi @Inversion-NL <https://github.com/Inversion-NL>. When you're
submitting pull requests can you please separate them into individual
requests that address specific functionalities. Having them all in a single
pull request makes it a really big job to review and delays acceptance of
the pull request as a whole. For example, if your change to update to Homey
2.0 is just, say, 50 lines then I can review that quickly and get it merged
for people to use. If those 50 lines are in a pull request with 500 other
lines to add various other functionalities then I have to review all 550
lines before I can merge the change that upgrades the app to Homey 2.0.
If instead you have, for example, a PR which just updates the app for
Homey 2. Then another that adds additional flow cards. Another that adds
auto-discovery etc. It means that I can review a small subset of the code
and get that merged to master more quickly. You can do it by creating
branches in your local github repository and raising a pull request for
each subset of functionality.
Does that make sense?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=ADZO66AGAC5RIO5M6YICTI3QKHUTBA5CNFSM4CQAUUNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67LDPA#issuecomment-532591036>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADZO66DAMZCRDO2IPF2X2TTQKHUTBANCNFSM4CQAUUNA>
.
|
Aanpassingen in package.json
Changed default port to 9000
Move server settings to device pairing for multiple server support
Added next, previous, seek, random and shuffle cards
Mobile card with on/off, play/pause, random and shuffle
Set device online and offline in Homey