[Grid] size proptype to accept grow and auto values #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablagoev
changed the title
DiegoAndai
reviewed
Feb 14, 2025
There was a problem hiding this comment.
Thanks for working on this @ablagoev!
May I ask you to run this command: pnpm test:update and check if there are any updates? If there are and they are related to this change, please commit them. If they're not related, let me know so I can take a look.
ablagoev
force-pushed
the
fix/grid-size-type
branch
from
4e16b32 to
da26ee3
Compare
|
Hey, Yes, I am sorry, I've missed this step in the process. I've updated the tests and squashed the commit. |
DiegoAndai
changed the title
DiegoAndai
changed the title
DiegoAndai
approved these changes
Feb 19, 2025
|
Thanks @ablagoev! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #323