-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take control over maybenot dependencies and verification #7515
base: main
Are you sure you want to change the base?
Take control over maybenot dependencies and verification #7515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. Solves the lockfile situation and makes static vs dynamic linking less messy. 👍
Reviewed 8 of 9 files at r1.
Reviewable status: 8 of 10 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 9 files at r1.
Reviewable status: 8 of 10 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some references to git submodule update --init --recursive --depth=1 wireguard-go-rs
(for example in the top-level README.md
). We should no longer need to checkout recursive submodules in wireguard-go-rs
😊
Reviewed 8 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Do we need to pass EDIT: Sorry, never mind, seems to be handled in the related |
cbindgen is no longer needed for building. The header generation is now done manually and never triggered automatically at build
8105490
to
6a87580
Compare
60029cc
to
b661f25
Compare
2a55782
to
8947760
Compare
8947760
to
b5da9be
Compare
This PR is a sibling-PR to mullvad/wireguard-go#22.
This switches to a version of the
wireguard-go
submodule wheremaybenot-ffi
is not included and built as a submodule. Instead there is a local crate inwireguard-go
that acts as a simple wrapper aroundmaybenot-ffi
, with helper files to build it for static linking. This allows us to include the wrapper (and transitively all its dependencies) in our main workspace and track all dependency versions and checksums here. This simplifies dependency management, reproducible builds and supply chain security checks.This PR is going to be colliding a bit with DAITA v2 for Windows (#7457), we have to discuss which one to get merged first.
Fixes DES-1360 and DES-1645
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)