doc: describe the default behaviour #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because for someone new, it might not be clear what it does. The idea is also to modify the welcome page on mptcpd.mptcp.dev with the same description. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Pull Request Test Coverage Report for Build 11889725129Details
💛 - Coveralls |
While describing what's being done by default, best to mention how to adapt that. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Thank you for the review @ossama-othman! I was going to merge this PR, but then I realised that while at it, it might be good to describe how to change the behaviour. So I just added a new paragraph about that if that's OK with you :) |
|
@matttbe Sure! No problem at all. Thanks! |
matttbe
added a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
matttbe
added a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
matttbe
added a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because for someone new, it might not be clear what it does.
The idea is also to modify the welcome page on mptcpd.mptcp.dev with the same description.
Note that I also modified the main wiki page with the same description.