Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mptcpize: set GODEBUG=multipathtcp=1 env var #316

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

matttbe
Copy link
Member

@matttbe matttbe commented Nov 21, 2024

GO apps don't use the libC, so the LD_PRELOAD technique doesn't work with these apps.

But since GO 1.21, MPTCP is natively supported, and can be forced by simply setting GODEBUG=multipathtcp=1. So mptcpize can easily support GO apps by also setting this env var.

Similar to the LD_PRELOAD env var, the GODEBUG one is appended with a comma if it was already set.

Link: https://go.dev/doc/godebug
Link: https://pkg.go.dev/net#Dialer.SetMultipathTCP

Depends-on: #315

@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 12993676243

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.075%

Totals Coverage Status
Change from base Build 12993653634: 0.0%
Covered Lines: 1409
Relevant Lines: 2199

💛 - Coveralls

Copy link
Member

@ossama-othman ossama-othman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GO apps don't use the libC, so the LD_PRELOAD technique doesn't work
with these apps.

But since GO 1.21, MPTCP is natively supported, and can be forced by
simply setting GODEBUG=multipathtcp=1. So mptcpize can easily support GO
apps by also setting this env var.

Similar to the LD_PRELOAD env var, the GODEBUG one is appended with a
comma if it was already set.

Link: https://go.dev/doc/godebug
Link: https://pkg.go.dev/net#Dialer.SetMultipathTCP
Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
@matttbe matttbe force-pushed the mptcpize-append-go branch from ee77b9c to b0c286d Compare January 27, 2025 16:33
@matttbe matttbe merged commit 68fd9a1 into multipath-tcp:main Jan 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants