Skip to content

Commit

Permalink
Merge PR #6256: FIX(client,theme): Use fixed dark font color for them…
Browse files Browse the repository at this point in the history
…eless notice labels

Previously, all "notice" labels had no font color assigned. That means they would use the selected themes default font color. This is fine, if the user would select any theme in Mumble.
However, if the user would select the 'None' theme, the font color would default to the systems default font color. And, if the user had a dark system theme, that would usually mean a very bright font color.
That very bright font color clashes with the hard-coded faint yellow and is therefore hard to read.

This commit hard-codes a dark font color for the notices. This will of course still be overwritten by the Mumble themes, if selected.

Fixes #6160
  • Loading branch information
Krzmbrzl authored Nov 4, 2023
2 parents be7c22e + c542973 commit 1e5a126
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/mumble/Themes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -144,5 +144,6 @@ bool Themes::readStylesheet(const QString &stylesheetFn, QString &stylesheetCont

QString Themes::getDefaultStylesheet() {
return QLatin1String(".log-channel{text-decoration:none;}.log-user{text-decoration:none;}p{margin:0;}#qwMacWarning,"
"#qwInlineNotice{background-color:#FFFEDC;border-radius:5px;border:1px solid #B5B59E;}");
"#qwInlineNotice{background-color:#FFFEDC;border-radius:5px;border:1px solid #B5B59E;}"
"#qwMacWarning > QLabel,#qwInlineNotice > QLabel{color:#333;}");
}

0 comments on commit 1e5a126

Please sign in to comment.