FEAT(client): Add MP3 Recording

[Chinry]

implements #3079

Checks

• My commits follow the commit guidelines

[Hartmnt]

@Chinry You can simply amend your changes and force push the branch :D There is no need to create new pull request for your changes. It helps to keep track of the discussion, you know.

[Chinry]

@Hartmnt, when I reset my changes it closed the request. Would it automatically reopen it once I pushed?

[Hartmnt]

Well, I do not really know what exactly you are doing, but it should be sufficient to do the following:

1. Change files
2. git add . (You may optionally replace . with any other file or folder)
3. git commit --amend (Here you can also change the commit message)
4. git push origin record-mp3 --force-with-lease (where record-mp3 is the branch name linked in the pull request)

That should push your changes to the existing pull request without closing it.

[Hartmnt]

Other than that it looks good. The translation commit is missing, of course. I will explain to you how to add the translation commit once I have had the time to test whether this new feature actually works ;)

[Chinry]

I appreciate the help with git. I made those 2 minor changes.

[Chinry]

@Hartmnt, how do I make a translation commit?

[Hartmnt]

@Hartmnt, how do I make a translation commit?

You run the scripts/updateTranslations.py script from the repo root. It automatically creates the commit.

However, for one I have not had the time to try your changes myself yet. And also your formatting is still failing (see the PR-Checks job log) and it would be (slightly) harder to update your commit when you have added the translation commit (git commit --amend would no longer work and you would have to fiddle with rebase)

[Chinry]

Not sure while it is failing after I ran clang-format on the file. It seems to have deleted some excess spaces that cause it to fail around line 81.

[Hartmnt]

Not sure while it is failing after I ran clang-format on the file. It seems to have deleted some excess spaces that cause it to fail around line 81.

Mhh, interesting. I assume you used clang-format in version 10? Anyway, it should be sufficient to revert to the line with the spaces intact. After all your main code changes did not even touch line 81.

[Chinry]

Fixed the formatting issue. Let me know when you get around to taking a look at the changes.

[Krzmbrzl]

I assume you have actually verified that recording to MP3 works with this code?
If that's true, then this LGTM. I'll take care of the translation updates for you.

[Hartmnt]

I just compiled and tested the branch. The mp3 recording seems to work. VLC recognizes the resulting file as mp3.
Edit: Or does it? I don't know about audio codecs

I would say it works as advertised

[Krzmbrzl]

@Hartmnt Thanks for double-checking!

@Chinry thanks for implementing this feature!