Skip to content

Commit

Permalink
[Maya] Add missing bones using mel command called from executeCommand
Browse files Browse the repository at this point in the history 
Given up on pure c++ implementation as it seems impossible to know what the correct process is without extensive trial and error... why there isn't an add influence function in the sdk I will never understand...
  • Loading branch information
@munkybutt
munkybutt committed Oct 20, 2023
1 parent f6414e0 commit a512555
Show file tree
Hide file tree
Showing 2 changed files with 99 additions and 89 deletions.
Binary file modified PYProjects/skin_plus_plus/dccs/maya/skin_plus_plus_pymaya_2023/skin_plus_plus_pymaya.pyd
View file
Binary file not shown.
188 changes: 99 additions & 89 deletions PYProjects/source/skin_plus_plus_pymaya/skin_plus_plus_pymaya.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -153,101 +153,111 @@ UINT getFirstFreeIndex(MPlug* arrayPlug)

MObject SkinManagerMaya::addMissingBones(BoneNamesVector& missingBoneNames, const UINT& skinnedBoneCount)
{
MStatus status;
MSelectionList selectionList;
MObject dependNode;
auto bindPosePlug = this->fnSkinCluster.findPlug("bindPose", false, &status);
if (status != MS::kSuccess)
{
throw std::runtime_error("Failed to find bindPose plug on skin cluster!");
}
MPlugArray connectedPlugs;
bindPosePlug.connectedTo(connectedPlugs, true, false, &status);
if (status != MS::kSuccess) throw std::runtime_error("bindPose not connected to array");

auto bindPoseNode = connectedPlugs[0].node();
MFnDependencyNode bindPose;
bindPose.setObject(bindPoseNode);
if (bindPose.typeName() != "dagPose") throw std::runtime_error("Dependency node not dagPose");

auto skinClusterMatrixArray = this->fnSkinCluster.findPlug("matrix", false, &status);
auto skinClusterLockWeightsArray = this->fnSkinCluster.findPlug("lockWeights", false, &status);

const UINT skinClusterMatrixArrayFreeIndex = getFirstFreeIndex(&skinClusterMatrixArray);
const UINT skinClusterLockWeightsArrayFreeIndex = getFirstFreeIndex(&skinClusterLockWeightsArray);

auto bindPoseMembersArray = bindPose.findPlug("members", false);
auto bindPoseParentsArray = bindPose.findPlug("parents", false);
auto bindPoseWorldMatrixArray = bindPose.findPlug("worldMatrix", false);

const UINT bindPoseMemberFreeIndex = getFirstFreeIndex(&bindPoseMembersArray);
const UINT bindPoseParentsArrayFreeIndex = getFirstFreeIndex(&bindPoseParentsArray);
const UINT bindPoseWorldMatrixArrayFreeIndex = getFirstFreeIndex(&bindPoseWorldMatrixArray);

MDGModifier dagModifier;
for (UINT i = 0; i < missingBoneNames.size(); i++)
{
auto i_plus_one = i + 1;
const auto newBoneIndex = skinnedBoneCount + i;
selectionList.add(missingBoneNames[i].c_str());
status = selectionList.getDependNode(i, dependNode);
if (status != MS::kSuccess)
{
auto message = fmt::format("Failed to get depend node for: {}!", missingBoneNames[i]);
throw std::runtime_error(message);
}
if (!isNodeValid(&dependNode))
{
auto message = fmt::format("Node is not a joint or transform: {}", missingBoneNames[i]);
throw std::runtime_error(message);
}
MFnIkJoint joint;
status = joint.setObject(dependNode);
if (status != MS::kSuccess)
{
auto message = fmt::format("Failed to get MFnIkJoint for: {}!", missingBoneNames[i]);
throw std::runtime_error(message);
}
auto jointMessage = joint.findPlug("message", false);
auto jointWorldMatrix = joint.findPlug("worldMatrix", false).elementByLogicalIndex(0);
auto jointLockInfluenceWeightsArray = joint.findPlug("lockInfluenceWeights", false);
auto jointBindPose = joint.findPlug("bindPose", false, &status);
if (status != MS::kSuccess)
{

auto message = fmt::format("Failed to find bindPose attribute for: {}!", missingBoneNames[i]);
throw std::runtime_error(message);
}

auto skinClusterMatrixIndex = skinClusterMatrixArray.elementByLogicalIndex(skinClusterMatrixArrayFreeIndex + i_plus_one);
auto skinClusterLockWeightsIndex = skinClusterLockWeightsArray.elementByLogicalIndex(skinClusterLockWeightsArrayFreeIndex + i_plus_one);

auto bindPoseMemberIndex = bindPoseMembersArray.elementByLogicalIndex(bindPoseMemberFreeIndex + i_plus_one);
auto bindPoseWorldMatrixIndex = bindPoseWorldMatrixArray.elementByLogicalIndex(bindPoseWorldMatrixArrayFreeIndex + i_plus_one);
auto bindPoseParentIndex = bindPoseParentsArray.elementByLogicalIndex(bindPoseParentsArrayFreeIndex + i_plus_one);

dagModifier.connect(jointWorldMatrix, skinClusterMatrixIndex);
dagModifier.connect(jointLockInfluenceWeightsArray, skinClusterLockWeightsIndex);

dagModifier.connect(jointMessage, bindPoseMemberIndex);
dagModifier.connect(jointBindPose, bindPoseWorldMatrixIndex);
dagModifier.connect(bindPoseMemberIndex, bindPoseParentIndex);
}
status = dagModifier.doIt();
if (status != MS::kSuccess)
{
throw std::runtime_error("Failed to add missing bones!");
}
std::string message = "Successfully added missing bones:";
for (std::string& name : missingBoneNames)
{
message += fmt::format(" - ", name);
auto command = fmt::format("skinCluster -e -ai {} {}", name, this->fnSkinCluster.name().asChar());
MGlobal::executeCommand(MString(command.c_str()));
}
py::print(message);
return bindPoseNode;
}


//MObject SkinManagerMaya::addMissingBones(BoneNamesVector& missingBoneNames, const UINT& skinnedBoneCount)
//{
// MStatus status;
// MSelectionList selectionList;
// MObject dependNode;
// auto bindPosePlug = this->fnSkinCluster.findPlug("bindPose", false, &status);
// if (status != MS::kSuccess)
// {
// throw std::runtime_error("Failed to find bindPose plug on skin cluster!");
// }
// MPlugArray connectedPlugs;
// bindPosePlug.connectedTo(connectedPlugs, true, false, &status);
// if (status != MS::kSuccess) throw std::runtime_error("bindPose not connected to array");
//
// auto bindPoseNode = connectedPlugs[0].node();
// MFnDependencyNode bindPose;
// bindPose.setObject(bindPoseNode);
// if (bindPose.typeName() != "dagPose") throw std::runtime_error("Dependency node not dagPose");
//
// auto skinClusterMatrixArray = this->fnSkinCluster.findPlug("matrix", false, &status);
// auto skinClusterLockWeightsArray = this->fnSkinCluster.findPlug("lockWeights", false, &status);
//
// const UINT skinClusterMatrixArrayFreeIndex = getFirstFreeIndex(&skinClusterMatrixArray);
// const UINT skinClusterLockWeightsArrayFreeIndex = getFirstFreeIndex(&skinClusterLockWeightsArray);
//
// auto bindPoseMembersArray = bindPose.findPlug("members", false);
// auto bindPoseParentsArray = bindPose.findPlug("parents", false);
// auto bindPoseWorldMatrixArray = bindPose.findPlug("worldMatrix", false);
//
// const UINT bindPoseMemberFreeIndex = getFirstFreeIndex(&bindPoseMembersArray);
// const UINT bindPoseParentsArrayFreeIndex = getFirstFreeIndex(&bindPoseParentsArray);
// const UINT bindPoseWorldMatrixArrayFreeIndex = getFirstFreeIndex(&bindPoseWorldMatrixArray);
//
// MDGModifier dagModifier;
// for (UINT i = 0; i < missingBoneNames.size(); i++)
// {
// auto i_plus_one = i + 1;
// const auto newBoneIndex = skinnedBoneCount + i;
// selectionList.add(missingBoneNames[i].c_str());
// status = selectionList.getDependNode(i, dependNode);
// if (status != MS::kSuccess)
// {
// auto message = fmt::format("Failed to get depend node for: {}!", missingBoneNames[i]);
// throw std::runtime_error(message);
// }
// if (!isNodeValid(&dependNode))
// {
// auto message = fmt::format("Node is not a joint or transform: {}", missingBoneNames[i]);
// throw std::runtime_error(message);
// }
// MFnIkJoint joint;
// status = joint.setObject(dependNode);
// if (status != MS::kSuccess)
// {
// auto message = fmt::format("Failed to get MFnIkJoint for: {}!", missingBoneNames[i]);
// throw std::runtime_error(message);
// }
// auto jointMessage = joint.findPlug("message", false);
// auto jointWorldMatrix = joint.findPlug("worldMatrix", false).elementByLogicalIndex(0);
// auto jointLockInfluenceWeightsArray = joint.findPlug("lockInfluenceWeights", false);
// auto jointBindPose = joint.findPlug("bindPose", false, &status);
// if (status != MS::kSuccess)
// {
//
// auto message = fmt::format("Failed to find bindPose attribute for: {}!", missingBoneNames[i]);
// throw std::runtime_error(message);
// }
//
// auto skinClusterMatrixIndex = skinClusterMatrixArray.elementByLogicalIndex(skinClusterMatrixArrayFreeIndex + i_plus_one);
// auto skinClusterLockWeightsIndex = skinClusterLockWeightsArray.elementByLogicalIndex(skinClusterLockWeightsArrayFreeIndex + i_plus_one);
//
// auto bindPoseMemberIndex = bindPoseMembersArray.elementByLogicalIndex(bindPoseMemberFreeIndex + i_plus_one);
// auto bindPoseWorldMatrixIndex = bindPoseWorldMatrixArray.elementByLogicalIndex(bindPoseWorldMatrixArrayFreeIndex + i_plus_one);
// auto bindPoseParentIndex = bindPoseParentsArray.elementByLogicalIndex(bindPoseParentsArrayFreeIndex + i_plus_one);
//
// dagModifier.connect(jointWorldMatrix, skinClusterMatrixIndex);
// dagModifier.connect(jointLockInfluenceWeightsArray, skinClusterLockWeightsIndex);
//
// dagModifier.connect(jointMessage, bindPoseMemberIndex);
// dagModifier.connect(jointBindPose, bindPoseWorldMatrixIndex);
// dagModifier.connect(bindPoseMemberIndex, bindPoseParentIndex);
// }
// status = dagModifier.doIt();
// if (status != MS::kSuccess)
// {
// throw std::runtime_error("Failed to add missing bones!");
// }
// std::string message = "Successfully added missing bones:";
// for (std::string& name : missingBoneNames)
// {
// message += fmt::format(" - ", name);
// }
// py::print(message);
// return bindPoseNode;
//}


PySkinData SkinManagerMaya::getData(const bool safeMode)
{
if (!this->isValid)
Expand Down

0 comments on commit a512555

Please sign in to comment.