optional postgress database #322 #370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please adhere to PEP8 and I'd recommend to not use an ORM. Also I'd like to see more than just a database connection 😉 |
|
Ok ill update you as soon as possible:+1:. |
|
@steve7158 please use async for your implementation :) |
|
Ok, @afeena ill do that 😃 . |
|
also please let me know if it is a good practice or not to make PR commits that are incomplete. I thought it of as a way to review my code. Thank you |
|
It's fine and recommended if you work on a project for the first time. Now you already got important feedback that helps you preparing a solid PR |
|
I see thank you @glaslos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@glaslos @afeena please check this PR if it is relevant to issue #322