Merge pull request #28 from mwakaba2/fix-icon-url

Fix icon path
mwakaba2 · Aug 8, 2021 · d516c0e · d516c0e
2 parents aa73a27 + 7f9f3cc
commit d516c0e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/binder/environment.yml b/binder/environment.yml
@@ -4,4 +4,4 @@ channels:
 dependencies:
 - jupyterlab>=3.1
 - pip:
-  - jupyterlab-notifications==0.3.1
+  - jupyterlab-notifications==0.3.2
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "jupyterlab-notifications",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "description": "Jupyterlab extension to show notebook cell completion browser notifications",
   "keywords": [
     "jupyter",

diff --git a/src/index.ts b/src/index.ts
@@ -6,6 +6,7 @@ import { KernelError, Notebook, NotebookActions } from '@jupyterlab/notebook';
 import { Cell } from '@jupyterlab/cells';
 import { ISettingRegistry } from '@jupyterlab/settingregistry';
 import { ICodeCellModel } from '@jupyterlab/cells';
+import { PageConfig } from '@jupyterlab/coreutils';
 import LRU from 'lru-cache';
 import moment from 'moment';
 import { checkBrowserNotificationSettings } from './settings';
@@ -28,8 +29,9 @@ function displayNotification(
   error: KernelError | null,
   lastCellOnly: boolean
 ): void {
+  const base = PageConfig.getBaseUrl();
   const notificationPayload = {
-    icon: '/static/favicon.ico',
+    icon: base + 'static/favicon.ico',
     body: ''
   };
   const title = failedExecution