Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement require_hash in the get method of Jupytext's content manager #1202

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Jan 9, 2024

Will close #1165

TODO:

  • Find out how to properly combine two hashes
  • Don't add a require_hash argument if the original contents manager does not have one
  • Add a test against jupyter_server==2.10.x

@mwouts mwouts marked this pull request as draft January 9, 2024 23:01
Copy link

github-actions bot commented Jan 9, 2024

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/mwouts/jupytext.git@implement_require_hash

(this requires nodejs, see more at Developing Jupytext)

@mwouts mwouts force-pushed the implement_require_hash branch from 2d4854b to e019b91 Compare December 10, 2024 22:32
@mwouts mwouts changed the base branch from main to fix_notebook_corruption_with_jupyter_collaboration December 10, 2024 22:41
@mwouts mwouts marked this pull request as ready for review December 10, 2024 22:41
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.02%. Comparing base (f2e1b9d) to head (22a307e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/jupytext/contentsmanager.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
- Coverage   97.03%   97.02%   -0.01%     
==========================================
  Files          29       29              
  Lines        4481     4501      +20     
==========================================
+ Hits         4348     4367      +19     
- Misses        133      134       +1     
Flag Coverage Δ
external 74.94% <64.00%> (-0.16%) ⬇️
functional 88.35% <52.00%> (-0.18%) ⬇️
integration 77.27% <88.00%> (+0.03%) ⬆️
unit 66.45% <56.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts mwouts force-pushed the fix_notebook_corruption_with_jupyter_collaboration branch from af4a8eb to 3dfd38b Compare December 15, 2024 16:04
Base automatically changed from fix_notebook_corruption_with_jupyter_collaboration to main December 15, 2024 17:21
@mwouts mwouts force-pushed the implement_require_hash branch 3 times, most recently from 70a6bf4 to 42ab63e Compare December 15, 2024 18:23
@mwouts mwouts force-pushed the implement_require_hash branch from 42ab63e to 22a307e Compare December 15, 2024 18:51
@mwouts mwouts merged commit d0e5b7a into main Dec 15, 2024
33 checks passed
@mwouts mwouts deleted the implement_require_hash branch December 15, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with jupyter_server 2.11.0
1 participant