fix: notation validator only on docker driver

mxab · Jan 2, 2024 · 7bd29ee · 7bd29ee
1 parent 1e0e64d
commit 7bd29ee
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/admissionctrl/validator/notation_validator.go b/admissionctrl/validator/notation_validator.go
@@ -17,6 +17,12 @@ type NotationValidator struct {
 func (v *NotationValidator) Validate(job *api.Job) ([]error, error) {
 	for _, tg := range job.TaskGroups {
 		for _, task := range tg.Tasks {
+			// check if the task driver is docker
+			// should we consider podman?
+			if task.Driver != "docker" {
+				continue
+			}
+
 			image, ok := task.Config["image"].(string)
 			if !ok {
 				continue

diff --git a/admissionctrl/validator/notation_validator_test.go b/admissionctrl/validator/notation_validator_test.go
@@ -91,6 +91,7 @@ func TestNotationValidatorValidate(t *testing.T) {
 			}{
 				{
 					driver: "magic",
+					image:  "invalidimage:latest",
 				},
 			},
 			expectedErrors: nil,
-Original file line number
+Diff line change
@@ Expand Up / @@ -91,6 +91,7 @@ func TestNotationValidatorValidate(t *testing.T) { @@
     			}{
     				{
     					driver: "magic",
+    					image:  "invalidimage:latest",
     				},
     			},
     			expectedErrors: nil,
@@ Expand Down @@