[Lint] - Fixed strange if #1540
Merged
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmjag
reviewed
Feb 3, 2025
| if ( | ||
| res is not False | ||
| not res |
There was a problem hiding this comment.
Suggested change
| not res | |
| res is not None |
Otherwise the semantics for this if statement changes.
For example not res will be True even for res = "", res = 0, not only res = None. Don't know if this actually make a difference in this code.
There was a problem hiding this comment.
load of the SampleChanger hardware object should now always return True or False. It used to be the the case, in the past that, None or True was returned for a successful load.
Your right the test should be changed, but to if res.
Thanks for spotting this one, I made a quick touch up before making the PR and made this mistake but it should be fine now.
marcus-oscarsson
force-pushed
the
mo-esrf-lint
branch
from
279ee9c to
42b2ff4
Compare
marcus-oscarsson
force-pushed
the
mo-esrf-lint
branch
from
42b2ff4 to
021aa5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the odd if statement, the sample changer HardwareObjects should now return True and not None or True on success.